From 823c28d38d52e395a089d86a10f7a9e41b2d5fb3 Mon Sep 17 00:00:00 2001 From: Kearwood Gilbert Date: Wed, 9 Sep 2026 23:32:05 -0700 Subject: [PATCH] Fix large allocation tests for mimir::Region --- tests/region_test.cpp | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/tests/region_test.cpp b/tests/region_test.cpp index 849c417..47969ad 100644 --- a/tests/region_test.cpp +++ b/tests/region_test.cpp @@ -33,14 +33,22 @@ TEST(Region, TooBig) { mimir::init(); mimir::Region region; - EXPECT_FALSE(region.init(1 << 44ULL)); // Attempt to allocate 16TB of pages + EXPECT_FALSE(region.init(1ULL << 50)); // Attempt to reserve too many pages +} + +TEST(Region, OutOfMemory) +{ + mimir::init(); + mimir::Region region; + EXPECT_TRUE(region.init(1ULL << 46)); // Attempt to reserve 64TB of pages + EXPECT_FALSE(region.resize(1ULL << 45)); // Attempt to commit 32TB of pages (Assuming we don't have 32TB of ram!) } TEST(Region, Min1GB) { mimir::init(); mimir::Region region; - EXPECT_TRUE(region.init(1 << 30ULL)); // Allocate 1GB of pages + EXPECT_TRUE(region.init(1ULL << 30)); // Allocate 1GB of pages } TEST(Region, Resizing) @@ -55,11 +63,11 @@ TEST(Region, Resizing) EXPECT_TRUE(region.resize(0)); EXPECT_EQ(region.getSize(), 0); - EXPECT_TRUE(region.resize(1 << 4ULL)); - EXPECT_TRUE(region.resize(1 << 10ULL)); - EXPECT_TRUE(region.resize(1 << 5ULL)); - EXPECT_TRUE(region.resize(1 << 0ULL)); - EXPECT_TRUE(region.resize(1 << 9ULL)); + EXPECT_TRUE(region.resize(1ULL << 4)); + EXPECT_TRUE(region.resize(1ULL << 10)); + EXPECT_TRUE(region.resize(1ULL << 5)); + EXPECT_TRUE(region.resize(1ULL << 0)); + EXPECT_TRUE(region.resize(1ULL << 9)); } TEST(Region, OverSized) @@ -67,10 +75,10 @@ TEST(Region, OverSized) mimir::init(); mimir::Region region; - EXPECT_TRUE(region.resize(1 << 4ULL)); + EXPECT_TRUE(region.resize(1ULL << 4)); size_t prevSize = region.getSize(); - EXPECT_FALSE(region.resize(1 << 20ULL)); + EXPECT_FALSE(region.resize(1ULL << 20)); EXPECT_EQ(region.getSize(), prevSize); }